Skip to content

fix/return err #2763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Dec 17, 2024
Merged

fix/return err #2763

merged 19 commits into from
Dec 17, 2024

Conversation

No-SilverBullet
Copy link
Member

based on issue #2762, fix some err return bugs.

xinfan.wu(吴歆帆) and others added 18 commits August 8, 2024 20:21
fix:set url to nil when destroy base invoker and change the order of …
8b9f2ec 
…related references to avoid panic
@No-SilverBullet
Merge pull request #1 from No-SilverBullet/fix/url_memory_leak
5033986 
fix:set url to nil when destroy base invoker
add comment at BaseInvoker.Destroy()
fb5763a
@No-SilverBullet
Merge pull request #2 from No-SilverBullet/fix/url_memory_leak
ca87720 
reafactor:add comment at  BaseInvoker.Destroy()
feat:add keepalive config and pass through to http2 transport
9bb0276
@No-SilverBullet
Merge branch 'apache:main' into main
a2b0d2f
Merge branch 'main' of github.com:No-SilverBullet/dubbo-go into feat/…
37ff642 
…triple_keepalive
chore:update comments for clarity
2d44df3
chore:update comments for clarity
59d2395
feat:add keepalive parameters to dubbogo/triple and preallocate the c…
e4680c1 
…onfig options to avoid memory copying and allocation caused by dynamic expansion of slices.
feat:add keepalive parameters, default interval is 10s, and timeout v…
8c3c67e 
…alue is 20s
fix:golang lint ci error
63400e8
fix:typo
4774b77
refactor:add space
31db567
refactor:add space for comment
a3190d0
refactor:add space for comment
930461a
fix err return which issued in issue2762
96a2a35
Merge branch 'develop' of github.com:No-SilverBullet/dubbo-go into fi…
e9d35cc 
…x/return_err
FoghostCn
FoghostCn requested changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@FoghostCn FoghostCn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dubbo-go/config/tls_config.go

Lines 54 to 59 in 37bc5c3

if err != nil {
return nil, err
}
if ok := ca.AppendCertsFromPEM(caBytes); !ok {
return nil, err
}

same problem;

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@No-SilverBullet
Copy link
Member Author

dubbo-go/config/tls_config.go

Lines 54 to 59 in 37bc5c3

if err != nil {
return nil, err
}
if ok := ca.AppendCertsFromPEM(caBytes); !ok {
return nil, err
}

same problem;

got it, already fixed

@FoghostCn FoghostCn linked an issue Dec 17, 2024 that may be closed by this pull request
Code bug: should return a error but return a nil value error #2762
Closed
@AlexStocks AlexStocks merged commit f3614e9 into apache:develop Dec 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoghostCn FoghostCn FoghostCn approved these changes

@AlexStocks AlexStocks AlexStocks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code bug: should return a error but return a nil value error
3 participants
@No-SilverBullet @FoghostCn @AlexStocks