Skip to content

Conversation

SHA-4096
Copy link
Contributor

@SHA-4096 SHA-4096 commented Jul 8, 2024

What's the purpose of this PR

Code merged in #2687 canot pass unit test related to methods and codec, due to additional methods added for compatibility. The following is done:

  • update ut related to methods
  • fixed a possible segmentation fault caused by a nil backupCodec

Copy link
Contributor

@FoghostCn FoghostCn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls fix ci

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The integration testing failure is caused by other reasons.

@chickenlj chickenlj merged commit cb400b2 into apache:main Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants