Compatibility/java interop #2687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Please run |
chickenlj
reviewed
Jun 14, 2024
| @@ -0,0 +1,18 @@ | |||
| package dubboutil | |||
There was a problem hiding this comment.
Add apache license header for this file
FoghostCn
reviewed
Jun 17, 2024
common/rpc_service.go
Outdated
| @@ -19,6 +19,7 @@ package common | |||
|
|
|||
| import ( | |||
| "context" | |||
| "dubbo.apache.org/dubbo-go/v3/common/dubboutil" | |||
chickenlj
reviewed
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of the change
1. handler mismatch
When interoperating with dubbo-java, there may be an issue when client from java side try to invoke an rpc function whose first-letter is in lower case, since dubbo-go now only provide handler whose method name is always with upper-cased first letter, due to the language feature of golang. It would cause failure in rpc function invocation, as mentioned in apache/dubbo-go-samples#771 .
To tackle this problem, a straightforward idea is to register another handler with a different first-letter case, and that's the change made by this pull request.
2. content-type codec mismatch
When using hessian2 for serialization, some version of java-side client would set a wrong content-type in request, causing marshal and unmarshal error. In order to tackle the problem, a backupCodec is introduced to handle the message in the server-side serialization type.
Validity of the solution
solution for problem 1
After adding a breakpoint at
dubbo-go/server/server.goat line 254, which is the section that exports service , we can see the registered handlers onservice->serviceOpts->rpsService->s->triServer->handlers, and/org.apache.dubbo.tri.hessian2.api.GreetingsService/greetis made possible by changes in this PR.solution for problem 2
A warn message would be logged when request content-type and server serialization mismatches, and the server would try to marshal/unmarshal message in server serialization codec.
