Improve cache init time and add application name #2420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #2420 +/- ##
==========================================
- Coverage 45.04% 45.03% -0.02%
==========================================
Files 269 269
Lines 18163 18167 +4
==========================================
- Hits 8182 8181 -1
- Misses 9109 9116 +7
+ Partials 872 870 -2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AlexStocks
reviewed
Sep 13, 2023
| "dubbo.apache.org/dubbo-go/v3/registry" | ||
| "dubbo.apache.org/dubbo-go/v3/registry/servicediscovery/store" | ||
| "dubbo.apache.org/dubbo-go/v3/remoting" | ||
| ) | ||
|
|
||
| var ( | ||
| metaCache *store.CacheManager | ||
| one sync.Once |
There was a problem hiding this comment.
Agreed, 'once' or 'XxxOnce' should be a better name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.