Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8c3057f) 46.79% compared to head (8c3057f) 46.79%.

❗ Current head 8c3057f differs from pull request most recent head 3ea9f56. Consider uploading reports for the commit 3ea9f56 to get more accurate results

@@           Coverage Diff           @@
##             main    #2405   +/-   ##
=======================================
  Coverage   46.79%   46.79%           
=======================================
  Files         317      317           
  Lines       22929    22929           
=======================================
  Hits        10730    10730           
  Misses      11157    11157           
  Partials     1042     1042           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

loadbalance benchmarks test.

goos: darwin
goarch: amd64
pkg: dubbo.apache.org/dubbo-go/v3/cluster/loadbalance
cpu: VirtualApple @ 2.50GHz
Benchmark_Roudrobin_Loadbalace-8                       	    6685	    165956 ns/op	   88100 B/op	    2555 allocs/op
Benchmark_Leastative_Loadbalace-8                      	    7554	    166090 ns/op	   81877 B/op	    2043 allocs/op
Benchmark_Consistenthashing_Loadbalace-8               	   55594	     21595 ns/op	    3425 B/op	     267 allocs/op
Benchmark_P2C_Loadbalace-8                             	 2525548	       467.7 ns/op	     456 B/op	      10 allocs/op
Benchmark_InterleavedWeightedRoundRobin_Loadbalace-8   	   19184	     63018 ns/op	   45296 B/op	    1027 allocs/op
Benchmark_Random_Loadbalace-8                          	   22238	     53121 ns/op	   38976 B/op	     767 allocs/op
PASS
ok  	dubbo.apache.org/dubbo-go/v3/cluster/loadbalance	9.925s

/cc @chickenlj PTAL

LGTM.

@chickenlj maybe this pr merge to master branch？

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
1.7% Duplication

Hi, I'm glad to see that dubbo-go uses the iwrr load balancing algorithm.

But I found that it is highly overlapped with the implementation I contributed in cloudwego/kitex#1019 (my original implementation). Following the apache 2.0 license, I hope to get copyright notice (with personal intentions), thank you.

Sorry for inconvenience, I'll take care of this later today.

Hi, I'm glad to see that dubbo-go uses the iwrr load balancing algorithm.

But I found that it is highly overlapped with the implementation I contributed in cloudwego/kitex#1019 (my original implementation). Following the apache 2.0 license, I hope to get copyright notice (with personal intentions), thank you.

We respect all creative inventions and copyrights. The contributor didn't mention that in the pull request, so we merged it based on the assumption that he is the code's original author.

I will revert this pull request now.

Hi, I'm glad to see that dubbo-go uses the iwrr load balancing algorithm.
But I found that it is highly overlapped with the implementation I contributed in cloudwego/kitex#1019 (my original implementation). Following the apache 2.0 license, I hope to get copyright notice (with personal intentions), thank you.

We respect all creative inventions and copyrights. The contributor didn't mention that in the pull request, so we merged it based on the assumption that he is the code's original author.

I will revert this pull request now.

Thanks, the later works (iwrr and alias method) will be assigned to @NX-Official, cc