CURATOR-720: Stop retry if client is closed #511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kezhuw
approved these changes
Dec 11, 2024
| @@ -399,6 +399,9 @@ void removeParentWatcher(Watcher watcher) { | |||
| public void internalBlockUntilConnectedOrTimedOut() throws InterruptedException { | |||
| long waitTimeMs = connectionTimeoutMs; | |||
| while (!state.isConnected() && (waitTimeMs > 0)) { | |||
| if (!started.get()) { | |||
| throw new IllegalStateException("Client is not started"); | |||
There was a problem hiding this comment.
+1 to this
This should cover both "not started" and "closed".
There was a problem hiding this comment.
How about "Client is not started or has been closed" ?
There was a problem hiding this comment.
Sounds good to me.
eolivelli
approved these changes
Dec 12, 2024
|
committed thank you @HoustonPutman |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/CURATOR-720
Stop a retry loop if the client is stopped.