Fix Issue 1709 - MERGE creates incomplete vertices after the first one (#1721) #1743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apache#1721) Fixed issue 1709 where MERGE appears to create incomplete vertices after the first one. However, the real issue was that SET wasn't seeing the newly created tuples from MERGE. This was due to an incorrect cid when performing the tuple insert in MERGE. The issue was that the cid was being overwritten in the function insert_entity_tuple_cid. Once this was corrected, everything worked fine. Added regression tests. Resolved Conflicts: src/backend/executor/cypher_utils.c NOTE: This patch has a regression test that is incorrect, noted in regress/sql/cypher_merge.sql under the issue. This issue needs to be looked into, but PG11 is basically not supported anymore. So, the PR was added as it does fix other issues with MERGE, just not this one particular one.
Zainab-Saad
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue 1709 where MERGE appears to create incomplete vertices after the first one. However, the real issue was that SET wasn't seeing the newly created tuples from MERGE. This was due to an incorrect cid when performing the tuple insert in MERGE.
The issue was that the cid was being overwritten in the function insert_entity_tuple_cid. Once this was corrected, everything worked fine.
Added regression tests.
Resolved Conflicts:
src/backend/executor/cypher_utils.c
NOTE: This patch has a regression test that is incorrect, noted in
regress/sql/cypher_merge.sql under the issue. This issue needs to
be looked into, but PG11 is basically not supported anymore. So,
the PR was added as it does fix other issues with MERGE, just not
this one particular one.