Skip to content

Clean up #included files in src/include directories (#1518) #1537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

jrgemignani
Copy link
Contributor

Cleaned up #included files in the .h files in the src/include directories.

Additionally, deleted 1 unnecessary header file.

modified:   src/include/catalog/ag_catalog.h
modified:   src/include/catalog/ag_graph.h
modified:   src/include/catalog/ag_label.h
modified:   src/include/catalog/ag_namespace.h
modified:   src/include/commands/graph_commands.h
modified:   src/include/commands/label_commands.h
modified:   src/include/executor/cypher_executor.h
modified:   src/include/executor/cypher_utils.h
modified:   src/include/nodes/ag_nodes.h
modified:   src/include/nodes/cypher_copyfuncs.h
modified:   src/include/nodes/cypher_nodes.h
modified:   src/include/nodes/cypher_outfuncs.h
modified:   src/include/nodes/cypher_readfuncs.h
modified:   src/include/optimizer/cypher_createplan.h
modified:   src/include/optimizer/cypher_pathnode.h
modified:   src/include/parser/cypher_clause.h
modified:   src/include/parser/cypher_expr.h
modified:   src/include/parser/cypher_gram.h
modified:   src/include/parser/cypher_item.h
modified:   src/include/parser/cypher_parse_node.h
modified:   src/include/parser/cypher_parser.h
modified:   src/include/parser/cypher_transform_entity.h
modified:   src/include/utils/ag_cache.h
modified:   src/include/utils/ag_float8_supp.h
modified:   src/include/utils/ag_func.h
modified:   src/include/utils/age_global_graph.h
modified:   src/include/utils/agtype.h
modified:   src/include/utils/agtype_parser.h
modified:   src/include/utils/agtype_raw.h
modified:   src/include/utils/graphid.h
modified:   src/include/utils/load/ag_load_edges.h
modified:   src/include/utils/load/ag_load_labels.h
modified:   src/include/utils/load/age_load.h

deleted:    src/include/utils/ag_load.h

Cleaned up #included files in the .h files in the src/include
directories.

Additionally, deleted 1 unnecessary header file.

    modified:   src/include/catalog/ag_catalog.h
    modified:   src/include/catalog/ag_graph.h
    modified:   src/include/catalog/ag_label.h
    modified:   src/include/catalog/ag_namespace.h
    modified:   src/include/commands/graph_commands.h
    modified:   src/include/commands/label_commands.h
    modified:   src/include/executor/cypher_executor.h
    modified:   src/include/executor/cypher_utils.h
    modified:   src/include/nodes/ag_nodes.h
    modified:   src/include/nodes/cypher_copyfuncs.h
    modified:   src/include/nodes/cypher_nodes.h
    modified:   src/include/nodes/cypher_outfuncs.h
    modified:   src/include/nodes/cypher_readfuncs.h
    modified:   src/include/optimizer/cypher_createplan.h
    modified:   src/include/optimizer/cypher_pathnode.h
    modified:   src/include/parser/cypher_clause.h
    modified:   src/include/parser/cypher_expr.h
    modified:   src/include/parser/cypher_gram.h
    modified:   src/include/parser/cypher_item.h
    modified:   src/include/parser/cypher_parse_node.h
    modified:   src/include/parser/cypher_parser.h
    modified:   src/include/parser/cypher_transform_entity.h
    modified:   src/include/utils/ag_cache.h
    modified:   src/include/utils/ag_float8_supp.h
    modified:   src/include/utils/ag_func.h
    modified:   src/include/utils/age_global_graph.h
    modified:   src/include/utils/agtype.h
    modified:   src/include/utils/agtype_parser.h
    modified:   src/include/utils/agtype_raw.h
    modified:   src/include/utils/graphid.h
    modified:   src/include/utils/load/ag_load_edges.h
    modified:   src/include/utils/load/ag_load_labels.h
    modified:   src/include/utils/load/age_load.h

    deleted:    src/include/utils/ag_load.h
@github-actions github-actions bot added the PG14 PostgreSQL14 label Feb 1, 2024
@rafsun42
Copy link
Member

rafsun42 commented Feb 1, 2024

@jrgemignani The changes in age_load.c in #1538 is not present in this PR. I am just curious if this is this intentional? Otherwise, looks good.

@dehowef
Copy link
Member

dehowef commented Feb 2, 2024

@jrgemignani The changes in age_load.c in #1538 is not present in this PR. I am just curious if this is this intentional? Otherwise, looks good.

It does not break anything with the tests, which leads me to think that it's fine, so I approved these changes, but I'll leave this unmerged for John to comment on. @rafsun42 @jrgemignani

@rafsun42 rafsun42 merged commit 5696cd5 into apache:PG14 Feb 2, 2024
@jrgemignani
Copy link
Contributor Author

@jrgemignani The changes in age_load.c in #1538 is not present in this PR. I am just curious if this is this intentional? Otherwise, looks good.

Each version needs some tweaking due to the changes in PostgreSQL for that version. So, it is expected that there will be some differences between the PRs for each version. The only time it is obvious is when there are conflicts that Github can't resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PG14 PostgreSQL14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants