Skip to content

Add Support for RTL text in most UI elements (#759) #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 27, 2025
Merged

Add Support for RTL text in most UI elements (#759) #760

merged 4 commits into from
Jul 27, 2025

Conversation

damageboy
Copy link
Contributor

@damageboy damageboy commented Jun 25, 2025 •
edited by aome510
Loading

Resolves #759

  • Search results
  • Playback Metadata/Rect
  • Main View
  • Playlist View

Before:
image

After:
image

@damageboy damageboy force-pushed the dmg/more_bidi branch 2 times, most recently from 6b5e36d to 61fdc2b Compare June 25, 2025 11:04
devceline
devceline reviewed Jun 26, 2025
View reviewed changes
Copy link
Contributor

@devceline devceline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this have any noticeable impact on performance? I considered doing this when I added the PR for lyrics but I thought the trade off might not be worth it.

@damageboy
Copy link
Contributor Author

damageboy commented Jun 28, 2025 •
edited
Loading

Not on my macbook pro m3, the code I lifted off of a previous PR is at least minimalistic in its approach by doing as little as possible if bidi strings are not at play...
So there's that...

devceline
devceline reviewed Jun 28, 2025
View reviewed changes
Copy link
Contributor

@devceline devceline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also re-use the same logic for lyrics

@damageboy
Copy link
Contributor Author

damageboy commented Jun 28, 2025 •
edited
Loading

Sure, I'll re-use the sI've unified everything to go through one impl of to_bidi_string() in ui::utils

Repushed @ f44cf86

@damageboy
Add Support for RTL text in most UI elements (aome510#759)
3157f02 
- Search results
- Playback Metadata/Rect
- Main View
- Playlist View
@aome510 aome510 merged commit e8b6164 into aome510:master Jul 27, 2025
5 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jul 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aome510 aome510 aome510 approved these changes

+1 more reviewer

@devceline devceline devceline left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RTL Support is sketchy/lacking
3 participants
@damageboy @aome510 @devceline