Feature: Add ability to jump to search result #748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aome510
reviewed
Jun 22, 2025
spotify_player/src/config/keymap.rs
Outdated
| @@ -107,6 +107,10 @@ impl Default for KeymapConfig { | |||
| key_sequence: "Z".into(), | |||
| command: Command::AddSelectedItemToQueue, | |||
| }, | |||
| Keymap { | |||
| key_sequence: "C-j".into(), | |||
There was a problem hiding this comment.
this definitely needs a new keybinding to avoid conflict with other command. Maybe g C. If you want C-j, you can bind it accordingly on your own configs
There was a problem hiding this comment.
Just to check, do you mean C g, I thought g C would enter the g into the search popup?
There was a problem hiding this comment.
C-J didn't seem to work, the combo wasn't even picked up by crossterm, so I have selected C-g as it doesn't conflict with anything.
aome510
approved these changes
Jul 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there's no way to jump to a search result within a playlist without first playing the song and using
JumpToCurrentTrackInContext. This PR adds the ability to jump directly to any search result in a playlist. After searching, highlight a result and press C-j to jump to its location in the playlist.The default keybind is C-j, which overlaps with
MovePlaylistItemDown. Whilst, the two don't conflict during search, I recognise this may not be desirable, so I can change the default if desired.