Skip to content

fix: Some shows not loading #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Conversation

m4r1vs
Copy link
Contributor

@m4r1vs m4r1vs commented Jan 16, 2025

fixes #663
Can be reverted once it is fixed upstream in rspotify

fixes aome510#663
Can be reverted once it is fixed upstream in rspotify
@m4r1vs
Copy link
Contributor Author

m4r1vs commented Jan 16, 2025

Not much experience with rust so I'm not sure if there is a cleaner way to copy all the properties of first_page without doing it explicitly like this..

@aome510
Copy link
Owner

aome510 commented Jan 17, 2025

Not much experience with rust so I'm not sure if there is a cleaner way to copy all the properties of first_page without doing it explicitly like this..

Normally, you can do

let first_page = rspotify::model::Page {
     items: first_page.items.into_iter().map(Some).collect(),
     ..first_page
 };

However, in this case, it's not possible because the type of items is changed from Vec<T> to Vec<Option<T>>

@aome510 aome510 merged commit 78edb10 into aome510:master Jan 17, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crosslinked issue on Podcasts not loading
2 participants