Skip to content

Cleanup config::theme codes #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 15, 2024
Merged

Cleanup config::theme codes #636

merged 3 commits into from
Dec 15, 2024

Conversation

aome510
Copy link
Owner

@aome510 aome510 commented Dec 15, 2024

  • avoid panic on lyrics page upon no playback
  • clean up codes in config/theme.rs

manh9203
manh9203 approved these changes Dec 15, 2024
View reviewed changes
Copy link

@manh9203 manh9203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aome510 aome510 merged commit 9020dbf into master Dec 15, 2024
5 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Dec 15, 2024
Merged
@aome510 aome510 deleted the cleanup-style-codes branch March 24, 2025 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@manh9203 manh9203 manh9203 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aome510 @manh9203