Use album id as hash to store album covers #514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is another approach which is by using the album id as the hash input to avoid collision where the same songs with different album covers write to the same hash. I will attempt to implement that. |
aome510
requested changes
Jul 23, 2024
spotify_player/src/client/mod.rs
Outdated
| saved: bool, | ||
| ) -> Result<Vec<u8>> { | ||
| let configs = config::get_config(); | ||
| let hashedname = crate::utils::hash_filename(filename); |
There was a problem hiding this comment.
you can append the hash at the end of the name instead. Also make it shorter, e.g use 6 characters instead of 16? The main idea to keep the album's name and artist's name is to make it easy for users to find
There was a problem hiding this comment.
I used 6 digits of the album id as the hash now
aome510
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #506
My attempt to address #506, this has been tested working on my windows machine, I do recommend more testing though, because with a small digest size, hash collision could occur. In that case, we could use a multi-folder caching technique.
I'm also new to rust, so hopefully I didn't break anything else :)