Skip to content

Add cross-platform default value for url_open_command #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 19, 2023
Merged

Add cross-platform default value for url_open_command #88

merged 5 commits into from
Apr 19, 2023

Conversation

aome510
Copy link
Owner

@aome510 aome510 commented Apr 19, 2023 •
edited
Loading

Resolves #87

@aome510 aome510 mentioned this pull request Apr 19, 2023
Closed
baodrate
baodrate approved these changes Apr 19, 2023
View reviewed changes
Copy link

@baodrate baodrate left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested against current master, resolves #87 perfectly, AFAICT 😊

@aome510 aome510 merged commit 902ae40 into main Apr 19, 2023
@aome510 aome510 deleted the cross-platform-open-command branch April 19, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@baodrate baodrate baodrate approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'open' command on Linux
2 participants
@aome510 @baodrate