Skip to content

Expand story view capabilities #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 5, 2022
Merged

Expand story view capabilities #80

merged 5 commits into from
Sep 5, 2022

Conversation

aome510
Copy link
Owner

@aome510 aome510 commented Sep 5, 2022 •
edited
Loading

Changes

  • introduce story sort mode to replace initial sort "by_date". Story sort mode includes: None, Date, and Point.
    • update story retrieving/constructing codes to use sort_mode as a parameter instead of by_date
  • if None sort mode is specified, use a combination of HN Algolia APIs and HN official APIs to retrieve ask_hn and show_hn stories in the same order as displayed in the http://news.ycombinator.com/ website.

Breaking changes

  • rename toggle_sort_by_date command to cycle_sort_mode

@aome510 aome510 merged commit 65ec605 into main Sep 5, 2022
@aome510 aome510 deleted the expand-story-view-caps branch September 5, 2022 04:20
@aome510 aome510 mentioned this pull request Sep 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aome510