Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: aome510/hackernews-TUI
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.13.2
Choose a base ref
...
head repository: aome510/hackernews-TUI
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.13.3
Choose a head ref
  • 2 commits
  • 12 files changed
  • 2 contributors

Commits on Aug 28, 2023

  1. Implement Rust native article view as fallback on failed `article_par… 

    …se_command` (#94)

### Summary

Implement Rust native article view as fallback on failed `article_parse_command`.

### Context

Current implementation will display a link to the [`config.md`](https://github.com/aome510/hackernews-TUI/blob/main/docs/config.md#article-parse-command) file if the `article_parse_command` fails. Almost all of new users will see this error. Instead, we can use the `readable-readability` to provide similar capability as a fallback method. This might be more user friendly and nice default behavior. 

### Dependency Added

- [`readable-readability`](https://crates.io/crates/readable-readability)

### Screenshots

https://news.ycombinator.com/item?id=37214693

|`article_md`|New implementation|
|-|-|
|![article_md 1](https://github.com/aome510/hackernews-TUI/assets/679719/a85e6f5b-d003-44c4-9270-72555535631d)|![integrated 1](https://github.com/aome510/hackernews-TUI/assets/679719/5edcc5d8-d339-431b-a331-90d51833df46)|

Please note that it's not perfect for some pages as below, but I think it'd be acceptable.

https://news.ycombinator.com/item?id=25607320

|`article_md`|New implementation|
|-|-|
|![aritcle_md 2](https://github.com/aome510/hackernews-TUI/assets/679719/87702be2-aa88-4169-8199-f83e677c761a)|![integrated 2](https://github.com/aome510/hackernews-TUI/assets/679719/1302615c-058b-4277-a97a-4d06ff439550)|
    @0x6b
    0x6b authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    70302c7 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2023

  1. Releasev0.13.3 (#95) 

    - update `CD` workflow to include more targets
- update dependencies and bump the app's version to `0.13.3`
    @aome510
    aome510 authored Sep 3, 2023
    Configuration menu
    Copy the full SHA
    3388376 View commit details
    Browse the repository at this point in the history
Loading