Skip to content

Conversation

icyJoseph
Copy link

@icyJoseph icyJoseph commented Mar 17, 2022

Default to false if the query is not passed.

Motivation

I often compete in various coding challenges, hackathons, etc., where I collaborate with people who use languages that are out of my scope. Often these repositories are marked as archived to filter them all at once.

Change

Adds exclude_archived as query for top languages. It defaults to false, which means it won't affect users who do not query for it.

TODO

  • Do we think tests are good enough?
  • Update readme.md with new behavior

Defaults to false if the query is not passed.
@vercel
Copy link

vercel bot commented Mar 17, 2022

@icyJoseph is attempting to deploy a commit to the github readme stats Team on Vercel.

A member of the Team first needs to authorize it.

@rickstaa rickstaa added the enhancement New feature or request. label May 3, 2022
@Falconerd
Copy link

Is this still being considered? I would enjoy this feature

@rickstaa
Copy link
Collaborator

rickstaa commented Jan 3, 2023

Is this still being considered? I would enjoy this feature

@Falconerd, thanks for your interest in this feature. Since we receive a lot of PRs and are a small team, we use #1935 to judge which PRs we should merge. You can therefore show your support for these PRs by leaving a 👍🏻. Since there is not yet a feature request open for this PR, you can also create an accompanying feature request to increase the visibility of this PR.

@icyJoseph
Copy link
Author

I'll try to update the PR with latest upstream changes, just in case 😅

@rickstaa
Copy link
Collaborator

rickstaa commented Jan 3, 2023

I'll try to update the PR with the latest upstream changes, just in case 😅

I will quickly check your PRs tomorrow! Do you think the exclude_archived parameter is also helpful for the stats-card?

@rickstaa rickstaa force-pushed the master branch 2 times, most recently from 86aafe8 to 8bc69e7 Compare January 21, 2023 16:47
@github-actions github-actions bot added ⭐ top pull request Top pull request. and removed ⭐ top pull request Top pull request. labels Jun 7, 2023
@github-actions github-actions bot removed the ⭐ top pull request Top pull request. label Aug 25, 2023
@github-actions github-actions bot added the ⭐ top pull request Top pull request. label Sep 13, 2023
@Vyvy-vi
Copy link

Vyvy-vi commented Sep 30, 2023

An issue related to the feature implemented in this PR has been opened recently (#2508)

@github-actions github-actions bot removed the ⭐ top pull request Top pull request. label Oct 4, 2023
@github-actions github-actions bot added the ⭐ top pull request Top pull request. label Oct 24, 2023
@github-actions github-actions bot removed the ⭐ top pull request Top pull request. label Dec 16, 2023
@github-actions github-actions bot added the ⭐ top pull request Top pull request. label Aug 7, 2024
@julius-boettger
Copy link

I would still like to see this feature! Any chance to get it reviewed/merged after there has been no activity for a year now?

@icyJoseph
Copy link
Author

@julius-boettger I might actually have time to rework it, I had totally forgotten about it 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request. ⭐ top pull request Top pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants