This repository was archived by the owner on Aug 1, 2025. It is now read-only.
less counting and proper list handling #183
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
less counting and proper list handling by creating empty list's (
list =[]
) and.append()
'ing items to them.My previous rookie mistake
I was creating a list like so
nW = [None] * newWhiteListlen
- Leaves us with a lot of uselessNone
valuesI was also keeping a count to use as an index. - I didn't need to do this because because we can
.append()
it to the end of the listThen I'd add items to the list at index it had counted to -
As you see there would be a lot of
None
values in the list that weren't being used and taking up RAM for no reason.