This repository was archived by the owner on Aug 1, 2025. It is now read-only.
remove error prone total_changes function introduced in #158 #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 1, 2020 04:19
|
development branch does not appear up-to-date with master so re-opening |
|
@mwoolweaver Thanks for the information.
I think it is better to get all the domain in the whitelist, including both regex and normal domains. I merged a previously opened PR so there's a merge conflict, can you fix it? |
|
@anudeepND see #164 for update. also accomplished in less commits |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/anudeepND/whitelist/pull/158/files/e58bf0e986d6d1942b40c33f1458619c2941ac1a#diff-ae558a92912d7c9374a906e64b4b158eR133
and
https://github.com/anudeepND/whitelist/pull/158/files/e58bf0e986d6d1942b40c33f1458619c2941ac1a#diff-6fea026f04d10fad806b3d3b71d7747aR129
IMO your only adding or removing and URL from the whitelist
WHERE type = 0 AND comment LIKE '%qjz9zk%'so that's all we should check for.Also worth noting is the number you're wanting to get back from
total_changesis the same as the number of domains added OR removed by the respective scripts.new version can be tested from here
https://github.com/mwoolweaver/whitelist/tree/devel
wget https://raw.githubusercontent.com/mwoolweaver/whitelist/devel/scripts/whitelist.py