Skip to content

docs: 文档校正，主要涉及属性：collapsedRows、calcTotals、calcSubTotals 和 width、height #1160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 9, 2022
Merged

docs: 文档校正，主要涉及属性：collapsedRows、calcTotals、calcSubTotals 和 width、height #1160

merged 5 commits into from
Mar 9, 2022

Conversation

stone-lyl
Copy link
Member

👀 PR includes

✨ Feature

  • New feature

🎨 Enhance

  • Code style optimization
  • Refactoring
  • Change the UI
  • Improve the performance
  • Type optimization

🐛 Bugfix

🔧 Chore

  • Test case
  • Docs / demos update
  • CI / workflow
  • Release version
  • Other ()

📝 Description

🖼️ Screenshot

Before After
❌ ✅
image image

🔗 Related issue link

🔍 Self Check before Merge

  • Add or update relevant Docs.
  • Add or update relevant Demos.
  • Add or update relevant TypeScript definitions.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2022 •
edited
Loading

🎊 PR Preview has been successfully built and deployed to https://s2-preview-pr-1160.surge.sh

@github-actions github-actions bot added the pr(documentation) documentation label Mar 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2022 •
edited
Loading

Size Change: 0 B

Total Size: 211 kB

ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/index.min.js 138 kB
./packages/s2-core/dist/style.min.css 362 B
./packages/s2-react/dist/index.min.js 70.1 kB
./packages/s2-react/dist/style.min.css 3.17 kB

compressed-size-action

@stone-lyl stone-lyl force-pushed the fix-adaptive-options branch from c9cd6e9 to 39e2a68 Compare March 9, 2022 07:28
@codecov
Copy link

codecov bot commented Mar 9, 2022 •
edited
Loading

Codecov Report

Merging #1160 (39e2a68) into master (ff524ab) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1160   +/-   ##
=======================================
  Coverage   72.83%   72.83%           
=======================================
  Files         178      178           
  Lines       13493    13493           
  Branches     3192     3192           
=======================================
  Hits         9827     9827           
  Misses       2344     2344           
  Partials     1322     1322
Impacted Files Coverage Δ
packages/s2-react/src/hooks/useResize.ts 72.61% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff524ab...39e2a68. Read the comment docs.

zxc0328
zxc0328 approved these changes Mar 9, 2022
View reviewed changes
Copy link
Member

@zxc0328 zxc0328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@lijinke666 lijinke666 merged commit 0becd56 into master Mar 9, 2022
@lijinke666 lijinke666 deleted the fix-adaptive-options branch March 9, 2022 11:20
@lijinke666
Copy link
Member

🎉 This PR is included in version @antv/s2-v1.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member

🎉 This PR is included in version @antv/s2-react-v1.11.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

wjgogogo pushed a commit that referenced this pull request Oct 25, 2023
@stone-lyl
docs: 文档校正，主要涉及属性：collapsedRows、calcTotals、calcSubTotals 和 width、heig…
08450c5 
…ht (#1160)

* docs: 修正 collapsedRows 属性的描述。

* docs: 修正 calcTotals 和 calcSubTotals 的使用错误

* feat: 将width、height 属性设置成可选值

* docs:  将 width、height 属性设置成可选值

* fix: set parameter of type 'CanvasCfg'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zxc0328 zxc0328 zxc0328 approved these changes

@yangzhanmei yangzhanmei Awaiting requested review from yangzhanmei

@xingwanying xingwanying Awaiting requested review from xingwanying

@wjgogogo wjgogogo Awaiting requested review from wjgogogo

@lijinke666 lijinke666 Awaiting requested review from lijinke666

@serializedowen serializedowen Awaiting requested review from serializedowen

@lcx-seima lcx-seima Awaiting requested review from lcx-seima

@qubaomingg qubaomingg Awaiting requested review from qubaomingg

@YardWill YardWill Awaiting requested review from YardWill

Assignees

@stone-lyl stone-lyl

Labels
pr(documentation) documentation released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛小计、总计文档有误 🙏 s2-react adaptive 为 true 时无须设置宽高
3 participants
@stone-lyl @lijinke666 @zxc0328