Skip to content

Conversation

stone-lyl
Copy link
Member

@stone-lyl stone-lyl commented Nov 3, 2022

👀 PR includes

✨ Feature

  • New feature

🎨 Enhance

  • Code style optimization
  • Refactoring
  • Change the UI
  • Improve the performance
  • Type optimization

🐛 Bugfix

🔧 Chore

  • Test case
  • Docs / demos update
  • CI / workflow
  • Release version
  • Other ()

📝 Description

🖼️ Screenshot

Before After
image image
image image

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

@stone-lyl stone-lyl enabled auto-merge (squash) November 3, 2022 12:26
@github-actions github-actions bot added the pr(fix) bug fix label Nov 3, 2022
@vercel
Copy link

vercel bot commented Nov 4, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
antvis-s2 ✅ Ready (Inspect) Visit Preview Nov 4, 2022 at 4:02AM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

你好, @stone-lyl CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复

Hello, @stone-lyl CI run failed, please click the [Details] button for detailed log information and fix it.

@github-actions github-actions bot removed the 🚨 lint failed 静态检查失败 label Nov 4, 2022
@github-actions github-actions bot removed the 🚨 test failed 单元测试挂了 label Nov 4, 2022
@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Base: 77.16% // Head: 77.12% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (9f267fa) compared to base (a4b14a8).
Patch coverage: 61.49% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1874      +/-   ##
==========================================
- Coverage   77.16%   77.12%   -0.04%     
==========================================
  Files         234      238       +4     
  Lines       11518    11740     +222     
  Branches     2449     2498      +49     
==========================================
+ Hits         8888     9055     +167     
- Misses       1258     1280      +22     
- Partials     1372     1405      +33     
Impacted Files Coverage Δ
...nteraction/brush-selection/base-brush-selection.ts 78.73% <ø> (+8.31%) ⬆️
packages/s2-core/src/sheet-type/pivot-sheet.ts 86.11% <ø> (ø)
packages/s2-core/src/sheet-type/table-sheet.ts 87.93% <ø> (ø)
packages/s2-core/src/utils/export/index.ts 73.63% <ø> (ø)
...ages/s2-core/src/utils/interaction/select-event.ts 93.61% <ø> (ø)
packages/s2-core/src/utils/merge.ts 90.32% <ø> (ø)
packages/s2-core/src/utils/number-calculate.ts 81.25% <0.00%> (-1.36%) ⬇️
packages/s2-core/src/utils/text.ts 40.75% <ø> (ø)
...s2-react/src/components/tooltip/custom-tooltip.tsx 64.28% <ø> (-2.39%) ⬇️
packages/s2-shared/src/utils/drill-down.ts 21.31% <ø> (ø)
... and 63 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stone-lyl stone-lyl merged commit 9da12a9 into master Nov 4, 2022
@stone-lyl stone-lyl deleted the fix-theme-error branch November 4, 2022 05:32
@lijinke666
Copy link
Member

🎉 This PR is included in version @antv/s2-v1.33.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

YardWill added a commit that referenced this pull request Nov 4, 2022
* docs: update the README.md (#1863)

* fix: 修复 mergedCell 缺失theme 导致的报错 (#1874)

* feat: 为合并单元格添加主题

* test: 添加合并单元格主题相关单测

* chore: 更新README (#1865)

Co-authored-by: Jinke Li <a1231236677287@163.com>

* fix: ts problem

Co-authored-by: 嘤嘤嘤 <yingying.xwy@antgroup.com>
Co-authored-by: stone <stone-lyl@users.noreply.github.com>
Co-authored-by: Jinke Li <a1231236677287@163.com>
YardWill added a commit that referenced this pull request Nov 11, 2022
* refactor: 支持 ts 严格模式 close #1742

* fix: 修复部分类型错误

* fix

* fix

* fix: 修复测试

* fix:

* fix: ts problem (#1876)

* docs: update the README.md (#1863)

* fix: 修复 mergedCell 缺失theme 导致的报错 (#1874)

* feat: 为合并单元格添加主题

* test: 添加合并单元格主题相关单测

* chore: 更新README (#1865)

Co-authored-by: Jinke Li <a1231236677287@163.com>

* fix: ts problem

Co-authored-by: 嘤嘤嘤 <yingying.xwy@antgroup.com>
Co-authored-by: stone <stone-lyl@users.noreply.github.com>
Co-authored-by: Jinke Li <a1231236677287@163.com>

* fix: 升级配置

* test: 修复测试

* chore: 修复类型错误

Co-authored-by: YardWill <YardWill@users.noreply.github.com>
Co-authored-by: 嘤嘤嘤 <yingying.xwy@antgroup.com>
Co-authored-by: stone <stone-lyl@users.noreply.github.com>
@lijinke666
Copy link
Member

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

wjgogogo pushed a commit that referenced this pull request Oct 25, 2023
* feat: 为合并单元格添加主题

* test: 添加合并单元格主题相关单测
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛version 1.33.0 版本详情表 鼠标滚动 报错,望尽快修复
3 participants