Skip to content

Conversation

stone-lyl
Copy link
Member

👀 PR includes

✨ Feature

  • New feature

🎨 Enhance

  • Code style optimization
  • Refactoring
  • Change the UI
  • Improve the performance
  • Type optimization

🐛 Bugfix

🔧 Chore

  • Test case
  • Docs / demos update
  • CI / workflow
  • Release version
  • Other ()

📝 Description

在做复制的时候,发现了圈选还存在一个问题: #1740
后面再修复吧。

🖼️ Screenshot

Before After
复制行头 复制列头
复制行头 复制列头

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

@vercel
Copy link

vercel bot commented Sep 8, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
antvis-s2 ✅ Ready (Inspect) Visit Preview Sep 9, 2022 at 8:54AM (UTC)

@github-actions github-actions bot added the pr(feature) new feature label Sep 8, 2022
@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #1742 (9aeffb6) into master (fc6c5a2) will decrease coverage by 0.13%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##           master    #1742      +/-   ##
==========================================
- Coverage   77.16%   77.03%   -0.14%     
==========================================
  Files         234      234              
  Lines       11454    11488      +34     
  Branches     2427     2439      +12     
==========================================
+ Hits         8839     8850      +11     
- Misses       1265     1268       +3     
- Partials     1350     1370      +20     
Impacted Files Coverage Δ
...interaction/brush-selection/col-brush-selection.ts 82.60% <ø> (-0.38%) ⬇️
...interaction/brush-selection/row-brush-selection.ts 81.39% <ø> (-0.43%) ⬇️
packages/s2-core/src/utils/export/copy.ts 85.36% <91.66%> (-2.73%) ⬇️
packages/s2-core/src/facet/base-facet.ts 81.32% <0.00%> (-2.97%) ⬇️
...ckages/s2-core/src/interaction/event-controller.ts 82.75% <0.00%> (+0.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

Size Change: +260 B (0%)

Total Size: 428 kB

Filename Size Change
./packages/s2-core/dist/index.min.js 167 kB +260 B (0%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/style.min.css 389 B
./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.cjs.js 21.7 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.esm.js 21.2 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.umd.js 60.3 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.umd.min.js 33.9 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/config.js 1.16 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/DOMElementFilter.js 1.87 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/event-map.js 1.18 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/events.js 1.55 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/get-node-text.js 300 B
./packages/s2-core/node_modules/@testing-library/dom/dist/get-queries-for-element.js 738 B
./packages/s2-core/node_modules/@testing-library/dom/dist/get-user-code-frame.js 810 B
./packages/s2-core/node_modules/@testing-library/dom/dist/helpers.js 1.07 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/index.js 1.14 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/label-helpers.js 1.05 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/matches.js 1.14 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/pretty-dom.js 1.47 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/all-utils.js 337 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/alt-text.js 573 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/display-value.js 713 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/index.js 418 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/label-text.js 1.8 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/placeholder-text.js 491 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/role.js 2.67 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/test-id.js 498 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/text.js 958 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/title.js 718 B
./packages/s2-core/node_modules/@testing-library/dom/dist/query-helpers.js 1.81 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/role-helpers.js 2.82 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/screen.js 1.51 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/suggestions.js 1.5 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/wait-for-element-to-be-removed.js 748 B
./packages/s2-core/node_modules/@testing-library/dom/dist/wait-for.js 2.38 kB
./packages/s2-react/dist/index.min.js 64.2 kB
./packages/s2-react/dist/style.min.css 3.21 kB
./packages/s2-vue/dist/index.min.js 20.4 kB
./packages/s2-vue/dist/style.min.css 1.61 kB

compressed-size-action

@stone-lyl stone-lyl merged commit 5a0a942 into master Sep 16, 2022
@stone-lyl stone-lyl deleted the feat-copy-data branch September 16, 2022 09:32
@lijinke666
Copy link
Member

🎉 This PR is included in version @antv/s2-v1.30.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

lijinke666 added a commit that referenced this pull request Oct 27, 2022
YardWill added a commit that referenced this pull request Nov 11, 2022
* refactor: 支持 ts 严格模式 close #1742

* fix: 修复部分类型错误

* fix

* fix

* fix: 修复测试

* fix:

* fix: ts problem (#1876)

* docs: update the README.md (#1863)

* fix: 修复 mergedCell 缺失theme 导致的报错 (#1874)

* feat: 为合并单元格添加主题

* test: 添加合并单元格主题相关单测

* chore: 更新README (#1865)

Co-authored-by: Jinke Li <a1231236677287@163.com>

* fix: ts problem

Co-authored-by: 嘤嘤嘤 <yingying.xwy@antgroup.com>
Co-authored-by: stone <stone-lyl@users.noreply.github.com>
Co-authored-by: Jinke Li <a1231236677287@163.com>

* fix: 升级配置

* test: 修复测试

* chore: 修复类型错误

Co-authored-by: YardWill <YardWill@users.noreply.github.com>
Co-authored-by: 嘤嘤嘤 <yingying.xwy@antgroup.com>
Co-authored-by: stone <stone-lyl@users.noreply.github.com>
@lijinke666
Copy link
Member

🎉 This issue has been resolved in version @antv/s2-v2.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member

🎉 This issue has been resolved in version @antv/s2-react-v2.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member

🎉 This issue has been resolved in version @antv/s2-vue-v2.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

wjgogogo pushed a commit that referenced this pull request Oct 25, 2023
* feat: 行头圈选复制完成

* feat: 列头圈选复制完成

* fix: 修复原有单测(copy)问题

* feat: 当合计行列在最后一层时,也可以被复制成功

* test: 添加行列头圈选复制的单测

* docs: 补充复制行列头的文档

* docs: 补充复制行列头的demo

* refactor: 重构 getBrushHeaderCopyable 方法

* test: 重构 getBrushHeaderCopyable copy 的单测

Co-authored-by: zishang <lyl275911@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🙏支持行头单元格内容的复制
2 participants