Skip to content

[Python3] Move the metadata into PEP 621-compliant pyproject.toml. #4153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 18, 2023
Merged

[Python3] Move the metadata into PEP 621-compliant pyproject.toml. #4153

merged 5 commits into from
May 18, 2023

Conversation

KOLANICH
Copy link
Contributor

@KOLANICH KOLANICH commented Mar 2, 2023

No description provided.

@ericvergnaud
Copy link
Contributor

Hi,
thanks for this but I suspect it affects the releasee process ?

@KOLANICH
Copy link
Contributor Author

KOLANICH commented May 2, 2023

It affects. Instead of python3 setup.py <needed args> one should call python3 -m build <needed args>

@ericvergnaud
Copy link
Contributor

ericvergnaud commented May 2, 2023 •
edited
Loading

Can you update the release docs accordingly ?
https://github.com/antlr/antlr4/blob/master/doc/releasing-antlr.md

@KOLANICH
Copy link
Contributor Author

KOLANICH commented May 2, 2023

In fact it turns out the fix in the docs is not needed, it is already prescribed to use python3 -m build there.

@ericvergnaud
Copy link
Contributor

@parrt blessed

KOLANICH added 5 commits May 17, 2023 15:32
@KOLANICH
Move the metadata from setup.py into setup.cfg
99811e2 
Signed-off-by: KOLANICH <KOLANICH@users.noreply.github.com>
@KOLANICH
Add pyproject.toml according to PEP 517 & PEP 518
6a0a1ea 
Signed-off-by: KOLANICH <KOLANICH@users.noreply.github.com>
@KOLANICH
Remove setup.py. Building should be done using python3 -m build
d620314 
Signed-off-by: KOLANICH <KOLANICH@users.noreply.github.com>
@KOLANICH
Move the metadata into PEP 621-compliant pyproject.toml.
a775ff1 
Signed-off-by: KOLANICH <KOLANICH@users.noreply.github.com>
@KOLANICH
Started collecting submodules automatically
9cbded2 
Signed-off-by: KOLANICH <KOLANICH@users.noreply.github.com>
@parrt
Copy link
Member

parrt commented May 17, 2023

Can you guys update the release doc so i know how to use non-setup.py?

@ericvergnaud
Copy link
Contributor

ericvergnaud commented May 18, 2023 via email

@parrt parrt added this to the 4.12.1 milestone May 18, 2023
@parrt parrt merged commit c9952af into antlr:dev May 18, 2023
@KOLANICH KOLANICH deleted the pyproject.toml branch May 18, 2023 21:04
@admin-token-bot admin-token-bot mentioned this pull request Jul 7, 2024
Closed
@bhaskar-allam bhaskar-allam mentioned this pull request Oct 25, 2024
Open
@ThatGhostToast ThatGhostToast mentioned this pull request Nov 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comp:build target:python3
Projects
None yet
Milestone
4.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@KOLANICH @ericvergnaud @parrt