Skip to content

Conversation

sharknoon
Copy link
Contributor

Hello,

the arrays literalNames and symbolicNames do not only contain strings, but also null. Therefore we should reflect that in the TypeScript type to prevent build errors in strict mode.

image
image

Thank you for your great work on the TypeScript target, loving it :)

Kind regards
Sharknoon

Signed-off-by: Josua Frank <josua.frank@daimlertruck.com>
@ericvergnaud
Copy link
Contributor

@parrt blessed

@parrt parrt added this to the 4.12.1 milestone Feb 28, 2023
@parrt parrt merged commit 90c4433 into antlr:dev Feb 28, 2023
@sharknoon sharknoon deleted the typescript-fixes branch March 1, 2023 06:52
asvishnyakov added a commit to VirtoCommerce/vc-frontend that referenced this pull request Mar 17, 2023
antlr4 has some issues with typescript typings, which should be fixed in 4.12.1:
antlr/antlr4#4147
antlr/antlr4#4149
asvishnyakov added a commit to VirtoCommerce/vc-frontend that referenced this pull request Mar 17, 2023
antlr4 has some issues with typescript typings, which should be fixed in 4.12.1:
antlr/antlr4#4147
antlr/antlr4#4149
jimidle pushed a commit to jimidle/antlr4 that referenced this pull request Mar 28, 2023
Signed-off-by: Josua Frank <josua.frank@daimlertruck.com>
Co-authored-by: Josua Frank <josua.frank@daimlertruck.com>
Signed-off-by: Jim.Idle <jimi@idle.ws>
@matthew-dean
Copy link

A lot of good TypeScript and JavaScript runtime improvements for 4.12.1. Might there be a release soon?

@sharknoon
Copy link
Contributor Author

I hope so, waiting for a release too :)

@Codex-
Copy link
Contributor

Codex- commented May 16, 2023

Also encountering this issue causing type checking to fail, hoping for 4.12.1 🙏

@parrt
Copy link
Member

parrt commented May 16, 2023

@jimidle @ericvergnaud are at a good spot for release?

@jimidle
Copy link
Collaborator

jimidle commented May 16, 2023 via email

@parrt
Copy link
Member

parrt commented May 17, 2023

Ok. maybe I can try I release this weekend? It would be nice to freshen the internal Google copy as well.

@jimidle
Copy link
Collaborator

jimidle commented May 17, 2023 via email

@ericvergnaud
Copy link
Contributor

@parrt all green here, I just submitted 2 minor PRs for you to merge. Nothing else pending on my side.

@KvanTTT
Copy link
Member

KvanTTT commented May 18, 2023

@parrt please merge this merge request: #4227

@parrt
Copy link
Member

parrt commented May 19, 2023

You release mechanism will need to copy the main branch of:

ok, is this something we can document in the release .md file?

@jimidle
Copy link
Collaborator

jimidle commented May 19, 2023 via email

@matthew-dean
Copy link

@jimidle

The release of v4.13.0 is now live in the new release only repo

Is there a way to pull this into a project? Can that be documented?

@jimidle
Copy link
Collaborator

jimidle commented May 22, 2023 via email

@jimidle
Copy link
Collaborator

jimidle commented May 22, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants