[C++] Switch to std::any and deprecate antlrcpp::Any #3395
Conversation
|
@mike-lischke I kept |
767bba0 to
557620d
Compare
There was a problem hiding this comment.
The patch looks good, however in the build output I see 3 warnings, that should be fixed. No idea when this creeped in, but I see now:
/tmp/BaseCppTest-main-1638301471082/TParser.cpp:79:29: warning: explicit capture of 'this' with a capture default of '=' is a C++20 extension [-Wc++20-extensions]
auto onExit = finally([=, this] {
Then we get a number of warnings because of the recently deprecated EMPTY_VOCABULARY.
And finally a (probably old) problem with an implicit switch fall through. See the C++ build output in CircleCI.
Can you fix those too?
It looks like has been fixed recently: #3393 |
|
Fixed everything except EMPTY_VOCABULARY. I'll fix that in a standalone CL. The C++20 warning was fixed in a separate CL after I noticed it. I had misread a preprocessor condition as checking for C++ 17 when it was checking for C++ 20. |
|
@parrt Another C++ patch to merge. There are some build errors, but from what I see they are all caused by configuration problems on CircleCI. |
|
Ok, yeah, I think I broke everything yesterday outside of Circleci |
Remove
antlrcpp::Anyin favor ofstd::any. Unfortunately there is no good story for backwards compatibility asstd::anyis a smaller feature set and only supportsstatic_cast.