[C++] Partially undo commit a8d828016e54adfc403326d8e56d93e7c75c27fc #3393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@parrt PTAL somewhat quickly. This is a simple revert of a previous change. That preprocessor condition needs to remain. Currently C++20 is required, when we intended C++17. The error is |
|
Thank you for the patch. The last weekend I tried to set up msbuild C++ compilation but it was failing with a similar error. I wanted to create an issue but it seems this patch fixes the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially undo a previous commit. I misread the original preprocessor condition. It is actually testing for C++ 20, not C++ 17. So it needs to stay otherwise compilers conformant to C++ 17 without any extensions will fail.