Skip to content

[C++] Modernize Vocabulary using std::string_view #3378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2021
Merged

[C++] Modernize Vocabulary using std::string_view #3378

merged 1 commit into from
Dec 7, 2021

Conversation

jcking
Copy link
Collaborator

@jcking jcking commented Nov 30, 2021

Update Vocabulary to use std::string_view where possible. This is part 1 of multiple patches which will migrate most uses to std::string_view where possible for generated grammars.

@jcking jcking force-pushed the cpp-vocab-string-view branch 6 times, most recently from 14881d6 to 809b8df Compare November 30, 2021 18:48
@jcking jcking force-pushed the cpp-vocab-string-view branch from 809b8df to 0d6263a Compare November 30, 2021 19:33
@jcking
Copy link
Collaborator Author

jcking commented Nov 30, 2021

@mike-lischke

@jcking jcking marked this pull request as ready for review November 30, 2021 21:10
mike-lischke
mike-lischke reviewed Dec 5, 2021
View reviewed changes
Copy link
Member

@mike-lischke mike-lischke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few minor comments/questions.

@mike-lischke
Copy link
Member

@parrt A C++ patch ready for merge.

@parrt parrt added this to the 4.9.4 milestone Dec 7, 2021
@parrt parrt merged commit ceac269 into antlr:master Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mike-lischke mike-lischke mike-lischke approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
target:cpp
Projects
None yet
Milestone
4.10
Development

Successfully merging this pull request may close these issues.
3 participants
@jcking @mike-lischke @parrt