Skip to content

[Dart] Workaround for windows build issue #3253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2021
Merged

[Dart] Workaround for windows build issue #3253

merged 1 commit into from
Oct 14, 2021

Conversation

lingyv-li
Copy link
Member

Fixes #3248

kaby76
kaby76 approved these changes Aug 9, 2021
View reviewed changes
Copy link
Contributor

@kaby76 kaby76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great. Ty!

@lingyv-li lingyv-li marked this pull request as ready for review August 12, 2021 00:02
@lingyv-li lingyv-li mentioned this pull request Oct 11, 2021
Closed
@parrt parrt added this to the 4.9.3 milestone Oct 14, 2021
@parrt parrt merged commit 23f93e0 into antlr:master Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@kaby76 kaby76 kaby76 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
target:dart
Projects
None yet
Milestone
4.9.3
Development

Successfully merging this pull request may close these issues.

Dart targets do not build on Windows, "parent" defined inconsistently in RuleContext
3 participants
@lingyv-li @kaby76 @parrt