[Dart] Add case changing char stream example #3246
Conversation
| return c; | ||
| } | ||
| if (upper) { | ||
| return String.fromCharCode(c).toUpperCase().codeUnitAt(0); |
There was a problem hiding this comment.
Please use something that doesn't change the length of the output character because it creates problems for mapping to input characters and actually such characters are not used in programming languages.
Your approach change ß to SS (2 chars), I've checked in sandbox:
void main() {
print("ß".toUpperCase());
}For instance, you can check the length of the output character, and if it is more than 1 then return the original char. See detail in my comment in a thread about case insensitivity.
There was a problem hiding this comment.
Thanks for the comment, that's a interesting discussion.
In this case it doesn't change the string length because of the .codeUnitAt(0) at the end, but your solution is better. Dart is also a bit special where its behaviour is inconsistent between JS and VM: dart-lang/sdk#6706
#3140 for Dart target.
Depends on #3119