fix: Restore missing changes to v4 of go runtime #3871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had not though about this, but I guess some of the fix PRs did not have one fix that was in the legacy version of the runtime, copied in to the v4 branch. This commit fixes that. Signed-off-by: Jim.Idle <jimi@gatherstars.com>
|
@parrt If you get a chance would please merge this, otherwise I will lose track of it ;) |
|
Will this break a bunch of Go-target parsers? In other word should I try to incorporate this into the galactic overlords codebase yet? |
|
No mate. The fix was already in the 1.x version. If anyone upgraded without
moving to v4, then they already had the fix. But as the fix was for
something that didn’t even compile before this, we can be assured that
nobody was using it.
…On Mon, Sep 12, 2022 at 01:38 Terence Parr ***@***.***> wrote:
Will this break a bunch of Go-target parsers? In other word should I try
to incorporate this into the galactic overlords codebase yet?
—
Reply to this email directly, view it on GitHub
<#3871 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJ7TMDW5RAC6PK5C6VWYTDV5YKKZANCNFSM6AAAAAAQGMCSCM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Cool. thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had not thought about this, but I guess some of the fix PRs were out of order and did not have one fix that was in the legacy version of the runtime, copied in to the v4 branch. This PR fixes that.
It is not worth doing yet another minor release as if anyone needs this exact fix, they can use the dev branch until the next release.
Signed-off-by: Jim.Idle jimi@gatherstars.com