fix: #2016 Fix Go template list reference, go runtime and got test te… #3848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mplate for list labels Signed-off-by: Jim.Idle <jimi@gatherstars.com>
KvanTTT
reviewed
Aug 30, 2022
runtime-testsuite/resources/org/antlr/v4/test/runtime/templates/Go.test.stg
Show resolved
Hide resolved
|
So what are we doing with this one guys? I can take out the generated comments if you wish, not a big deal for me. If we can merge and close this, then Go is is good to go. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #2016 Fix runtime, test templates and go codegen template
The go Runtime was confused about the EmprtyPredictionContext vs SIngletonPredictionContext.
For now, I have fixed up the go code for merge(), but I think longer term I will have to change the way the structures for
prediction context are organized, which is a piece of work that isn't worth it for v4.11. I will come back to that.