Skip to content

[C++] Improve multithreaded performance, fix TSAN error, and fix profiling ATN simulator setup #3544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2022
Merged

[C++] Improve multithreaded performance, fix TSAN error, and fix profiling ATN simulator setup #3544

merged 1 commit into from
Feb 16, 2022

Conversation

jcking
Copy link
Collaborator

@jcking jcking commented Feb 16, 2022

Various small improvements.

  • Improve multithreaded performance by using insert instead of find then insert. This reduces the amount of time spent in critical sections.
  • Fix extremely rare race condition that I introduced as I unlocked then dereferenced an iterator.
  • Fix parser profiling setup. Currently calling setProfile more than once would crash in debug builds.

@jcking
Copy link
Collaborator Author

jcking commented Feb 16, 2022

@mike-lischke

mike-lischke
mike-lischke approved these changes Feb 16, 2022
View reviewed changes
Copy link
Member

@mike-lischke mike-lischke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@parrt This C++ patch can be merged.

@parrt parrt added this to the 4.10 milestone Feb 16, 2022
@parrt
Copy link
Member

parrt commented Feb 16, 2022

awesome patch. thanks!

@parrt parrt merged commit dc95a7d into antlr:dev Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mike-lischke mike-lischke mike-lischke approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
target:cpp
Projects
None yet
Milestone
4.10
Development

Successfully merging this pull request may close these issues.
3 participants
@jcking @parrt @mike-lischke