Skip to content

Conversation

jcking
Copy link
Collaborator

@jcking jcking commented Dec 23, 2021

No description provided.

@jcking
Copy link
Collaborator Author

jcking commented Dec 23, 2021

@mike-lischke A small improvement to MurmurHash to enable clang to better optimize. Hashing is in the critical path, so the faster the better.

@jcking
Copy link
Collaborator Author

jcking commented Dec 23, 2021

Note that it looks like I changed the constants with the diff in Github, but I really just switched their places. The 64-bit murmur is the first one now instead of the second.

@jcking jcking requested a review from mike-lischke December 23, 2021 18:53
Copy link
Member

@mike-lischke mike-lischke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@parrt Another C++ patch to merge.

@parrt parrt added this to the 4.9.4 milestone Dec 24, 2021
@parrt parrt merged commit 51c38f4 into antlr:master Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants