Skip to content

Fix template issue #2906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 15, 2020
Merged

Fix template issue #2906

merged 2 commits into from
Sep 15, 2020

Conversation

ericvergnaud
Copy link
Contributor

Fix #2745 (nb would be great to have a test that reproduces the issue)

@ericvergnaud
Copy link
Contributor Author

The test would be a small grammar that triggers NonLocalAttrRef and SetNonLocalAttr string template atoms

@ericvergnaud
Copy link
Contributor Author

@parrt blessed

@parrt parrt merged commit da84815 into master Sep 15, 2020
@ericvergnaud ericvergnaud deleted the fix-template-issue branch October 2, 2020 09:37
@parrt parrt added this to the 4.9 milestone Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
target:javascript
Projects
None yet
Milestone
4.9
Development

Successfully merging this pull request may close these issues.

Python3 parser generation incorrect by ANTLR 4.7.1 and problem in Parser.py
2 participants
@ericvergnaud @parrt