adding perlin noise functionality #74
Conversation
noise/noise.go
Outdated
| "math/rand" | ||
| "time" | ||
|
|
||
| "github.com/anthonynsimon/bild/parallel" | ||
| "github.com/roz3x/bild/perlin" |
There was a problem hiding this comment.
Could you please rewrite it to use the github.com/anthonynsimon/bild/perlin package?
There was a problem hiding this comment.
okay ! would be done soon .
main.go
Outdated
| "os" | ||
|
|
||
| "github.com/roz3x/bild/noise" | ||
| ) | ||
|
|
||
| func main() { |
There was a problem hiding this comment.
Please undo the changes to the CLI entrypoint :)
There was a problem hiding this comment.
Also you don't need to include the files in the output/* directory, otherwise they will be downloaded on every install by the project users.
There was a problem hiding this comment.
sorry my bad, i changed it for testing purpose .
There was a problem hiding this comment.
okay i will delete the output folder , but where would i host the images then ?!
|
|
||
| ### Perlin Noise | ||
| result := noise.PerlinGenerate(800,800,0.2) | ||
|  |
There was a problem hiding this comment.
Looks great! I will add the image blob to the main repo once it's merged too.
|
I will host them with the others, no worries :)
…On Sat 14. Sep 2019 at 02:12, roz3x ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In main.go
<#74 (comment)>:
> @@ -1,7 +1,14 @@
package main
-import "github.com/anthonynsimon/bild/cmd"
+import (
+ "image/png"
+ "os"
+
+ "github.com/roz3x/bild/noise"
+)
func main() {
okay i will delete the output folder , but where would i host the images
then ?!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#74?email_source=notifications&email_token=ADFDEB6RDS4KNFFQJPAPN4DQJQT5PA5CNFSM4IUT3HQKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCEXQT6A#discussion_r324402709>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADFDEB4LFDUR4PNS3C676W3QJQT5PANCNFSM4IUT3HQA>
.
|
|
thanks ! but you have to change the link in README too . |
|
@roz3x looks great 🎉 thanks a lot for your help! |
|
hey Thanks ! |
No description provided.