-
-
Notifications
You must be signed in to change notification settings - Fork 58
Closed
Labels
enhancementNew feature or requestNew feature or request
Description
Clear and concise description of the problem
In package.json - schema, the workspaces
should be able to be an object.
However, our project only considered it as a string array.
bumpp/src/normalize-options.ts
Lines 133 to 137 in 35fade1
// check npm/bun workspace config | |
if (fsSync.existsSync('package.json')) { | |
const packageJson = await fs.readFile('package.json', 'utf8').then(JSON.parse) as { workspaces?: string[] } | |
workspaces.push(...(packageJson.workspaces ?? [])) | |
} |
Suggested solution
According to the scheme, improve the parsing process.
Alternative
No response
Additional context
The current demand is actually because of bun.
As far as I know, the bun workspace configuration can only be set in package.json (of course, I might be wrong).
So if a complex workspace configuration is needed (for example, the configuration of the dependent catalog), it is necessary to use objects
to configure the workspaces
.
I am willing to provide a pr for this.
Validations
- Follow our Code of Conduct
- Read the Contributing Guide.
- Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request