This repository was archived by the owner on Feb 7, 2024. It is now read-only.
feat: support grammar injection #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for shikiji ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
==========================================
+ Coverage 96.85% 96.87% +0.02%
==========================================
Files 44 44
Lines 3562 3587 +25
Branches 471 477 +6
==========================================
+ Hits 3450 3475 +25
Misses 112 112 ☔ View full report in Codecov by Sentry. |
This was referenced Dec 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports text grammar's language injection (https://code.visualstudio.com/api/language-extensions/syntax-highlight-guide#injection-grammars). I am quite surprised it's really simple API stuff, while Shiki didn't implement it already.
Grammar injection is quite commonly used. Here is an example of Vue injecting syntax highlights for HTML:
Before:
After:
