feat: add $rejectPendingCalls
#26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
829115b to
6533e1c
Compare
antfu
approved these changes
Jul 14, 2025
sheremet-va
requested changes
Jul 14, 2025
src/index.ts
Outdated
| @@ -278,6 +291,16 @@ export function createBirpc<RemoteFunctions = Record<string, never>, LocalFuncti | |||
| off(onMessage) | |||
| } | |||
|
|
|||
| function rejectPendingCalls(handler: PendingCallHandler) { | |||
There was a problem hiding this comment.
The naming seems confusing because you are not required to reject it, it just calls a function on every entry
sheremet-va
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On Vitest we need to reject pending methods on Worker side. While
rpc.$closedoes this perfectly, we cannot use it. We are using the rpc channel for transferring the rejected methods, so$closeis closing the channel before rejection are sent to main thread.This PR adds new method that can be used to explicitly reject the pending methods.
Linked Issues
Error: [vitest-worker]: Timeout calling "onTaskUpdate"vitest-dev/vitest#8164Additional context