Skip to content

fix: Propagate node name for nested arrays #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2024
Merged

fix: Propagate node name for nested arrays #18

merged 1 commit into from
Mar 15, 2024

Conversation

srebhan
Copy link
Contributor

@srebhan srebhan commented Mar 11, 2024

When parsing nested arrays such as

{
	"values": [
		[
			1,
			2,
			3
		]
	]
 }

the XML equivalent looks like

<?xml version="1.0" encoding="utf-8"?>
<root>
	<values>
		<>1</>
		<>2</>
		<>3</>
	</values>
</root>

with a missing element name for the inner (an all additional nestings) array elements.

This PR propagates the node name down the processing stream to also name the inner elements according to the parent. For the example above this results in

<?xml version="1.0" encoding="utf-8"?>
<root>
	<values>
		<values>1</values>
		<values>2</values>
		<values>3</values>
	</values>
</root>

@srebhan srebhan mentioned this pull request Mar 12, 2024
Closed
@srebhan
Copy link
Contributor Author

srebhan commented Mar 15, 2024

@zhengchun any chance you take a look?

@zhengchun zhengchun merged commit 5db0be8 into antchfx:master Mar 15, 2024
@srebhan
Copy link
Contributor Author

srebhan commented Mar 15, 2024

@zhengchun thanks!!! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srebhan @zhengchun