Skip to content

feat: ConfigProvider support classNames and styles for Steps #53789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 59 commits into from
May 13, 2025
Merged

feat: ConfigProvider support classNames and styles for Steps #53789

merged 59 commits into from
May 13, 2025

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented May 9, 2025 •
edited
Loading

中文版模板 / Chinese template

🤔 This is a ...

  • 🆕 New feature
  • 🐞 Bug fix
  • 📝 Site / documentation improvement
  • 📽️ Demo improvement
  • 💄 Component style improvement
  • 🤖 TypeScript definition improvement
  • 📦 Bundle size optimization
  • ⚡️ Performance optimization
  • ⭐️ Feature enhancement
  • 🌐 Internationalization
  • 🛠 Refactoring
  • 🎨 Code style optimization
  • ✅ Test Case
  • 🔀 Branch merge
  • ⏩ Workflow
  • ⌨️ Accessibility improvement
  • ❓ Other (about what?)

🔗 Related Issues

  • Describe the source of related requirements, such as links to relevant issue discussions.
  • For example: close #xxxx, fix #xxxx

💡 Background and Solution

  • Steps 重构 DOM 以语义化结构实现
  • 替换所有 hardcode 的数值为 token
  • 替换 Progress hardcode 内容为 svg css var 版本
  • status 替换为纯 css var 实现
  • 支持 panel 形态
  • wireframe 移除，并改成 variant outlined 变体提供
  • 移除 max desc width 改为纯 flex 实现
  • 废弃 API 提示，移除结构语法糖
  • 分离 status 和 active 状态，现在切换有更明显的标识
  • 内联样式支持 offset 偏移、二级标题

📝 Change Log

Language Changelog
🇺🇸 English Steps support semantic structure and support ConfigProvider config. 更多内容看 issue 描述。
🇨🇳 Chinese Steps 支持语义化结构并且支持通过 ConfigProvider 进行配置。

zombieJ added 28 commits April 29, 2025 10:53
@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented May 9, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

thinkasany
thinkasany reviewed May 12, 2025
View reviewed changes
thinkasany
thinkasany reviewed May 12, 2025
View reviewed changes
@thinkasany
Copy link
Member

考虑手动点击切换步骤的时候，加点 Button 那种动效不，隔壁有一点效果，但是也不是很好看，不确定～。
https://mui.com/material-ui/react-stepper/#non-linear
image

thinkasany
thinkasany reviewed May 13, 2025
View reviewed changes
thinkasany
thinkasany reviewed May 13, 2025
View reviewed changes
thinkasany
thinkasany reviewed May 13, 2025
View reviewed changes
@thinkasany
Copy link
Member

thinkasany commented May 13, 2025 •
edited
Loading

这种 demo 能不能加个 segmented 合并一下，或者是直接合并。总感觉占了好多 demo，但是用处又不是很大的样子。
image

image
image

@thinkasany
Copy link
Member

点击的demo hover 也许可以加个 cursor: 'point'
image
image

@zombieJ
Copy link
Member Author

zombieJ commented May 13, 2025

这种 demo 能不能加个 segmented 合并一下，或者是直接合并。总感觉占了好多 demo，但是用处又不是很大的样子。

截图对比要用，可以合一部分，debug 一部分

thinkasany
thinkasany reviewed May 13, 2025
View reviewed changes
@thinkasany
Copy link
Member

这种 demo 能不能加个 segmented 合并一下，或者是直接合并。总感觉占了好多 demo，但是用处又不是很大的样子。

截图对比要用，可以合一部分，debug 一部分

也可以先不管，创个 Help wanted 的 issue 看社区同学的想象力，这个 PR 已经很大了，来回改太折腾了~

thinkasany
thinkasany reviewed May 13, 2025
View reviewed changes
thinkasany
thinkasany reviewed May 13, 2025
View reviewed changes
thinkasany
thinkasany reviewed May 13, 2025
View reviewed changes
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 13, 2025
@zombieJ zombieJ merged commit 8db39e3 into next May 13, 2025
17 of 18 checks passed
@zombieJ zombieJ deleted the steps-semantic branch May 13, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkasany thinkasany thinkasany approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zombieJ @thinkasany