fix: submenu should also follow Menu's style #50626

KevinZonda · 2024-08-28T15:06:16Z

🤔 This is a ...

🔗 Related Issues

💡 Background and Solution

There is no option for setting SubMenu item's hover, selected colour. So I guess it should follow the Menu one? And the style is not used in current codebase.

📝 Change Log

Language	Changelog
🇺🇸 English	Submenu may follow menu's theme setting.
🇨🇳 Chinese	子目录将遵循目录的主题设定

Signed-off-by: Xiang Shi <realkevin@tutanota.com>

bolt-new-by-stackblitz · 2024-08-28T15:06:20Z

Run & review this pull request in StackBlitz Codeflow.

github-actions · 2024-08-28T15:06:29Z

github-actions · 2024-08-28T15:06:30Z

👁 Visual-Regression Diff Building... ⏳

This PR is under visual-regression-diff building, please wait for the result.

afc163 · 2024-08-28T15:15:21Z

原始问题描述一下先？

KevinZonda · 2024-08-29T14:18:28Z

原始问题描述一下先？

Hi，就是如果我通过 ThemeProvider 给组件修改样式时候，对 item 进行属性修改之后只会对单item进行配置，而不会对有 submenu 的选项修改

我的主题相关

Menu: {
            colorItemBgHover: MAIN_COLOUR,
            colorItemBgSelected: MAIN_COLOUR,
            colorPrimary: MAIN_COLOUR,
            colorItemTextSelected: "white",
            colorItemTextHover: "white",
            colorIconHover: "white",
            subMenuItemBg: "white",
            itemBorderRadius: 0,
          },

Hover 的行为：
单Item：

Item	包含 SubMenu的Item

以及Select的行为也会有差异

Item	Item w SubMenu

afc163 · 2024-09-03T15:51:18Z

ci 挂了

coderabbitai · 2025-04-13T13:42:57Z

Warning

Rate limit exceeded

@afc163 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 17 minutes and 40 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 9b75868 and 03d9e41.

📒 Files selected for processing (1)

components/menu/SubMenu.tsx (3 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

afc163 · 2025-04-13T13:43:04Z

Ping，看看 ci 报错的问题。

thinkasany · 2025-04-22T09:24:42Z

components/menu/SubMenu.tsx

@@ -72,6 +74,7 @@ const SubMenu: React.FC<SubMenuProps> = (props) => {
          popupClassName,
          `${prefixCls}-${customTheme || contextTheme}`,
        )}
+        style={{ ...menu?.style, ...style }}


实际上还是会有一些场景，menu 和 subMenu 样式不一样。 v6 会通过语义化去解决。当前这么做很容易造成样式污染，就先关了，欢迎 reopen 或继续讨论。

#53324

<Menu classNames={{ subMenu: { itemTitle: 'my-classname' } }} styles={{ subMenu: { itemTitle: { color: 'red' } } }} />

fix: submenu should also follow Menu's style

03ac905

Signed-off-by: Xiang Shi <realkevin@tutanota.com>

afc163 added 3 commits January 21, 2025 16:50

Merge branch 'master' into patch-1

b438d4c

Merge branch 'master' into patch-1

37b389f

Merge branch 'master' into patch-1

03d9e41

thinkasany mentioned this pull request Apr 22, 2025

feat: ConfigProvider support classNames and styles for menu #53324

Merged

1 task

thinkasany reviewed Apr 22, 2025

View reviewed changes

thinkasany closed this Apr 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: submenu should also follow Menu's style #50626

fix: submenu should also follow Menu's style #50626

Uh oh!

KevinZonda commented Aug 28, 2024

Uh oh!

bolt-new-by-stackblitz bot commented Aug 28, 2024

Uh oh!

github-actions bot commented Aug 28, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Aug 28, 2024 •

edited

Loading

Uh oh!

afc163 commented Aug 28, 2024

Uh oh!

KevinZonda commented Aug 29, 2024

Uh oh!

afc163 commented Sep 3, 2024

Uh oh!

coderabbitai bot commented Apr 13, 2025

Rate limit exceeded

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

afc163 commented Apr 13, 2025

Uh oh!

thinkasany Apr 22, 2025

Uh oh!

Uh oh!

Uh oh!

fix: submenu should also follow Menu's style #50626

fix: submenu should also follow Menu's style #50626

Uh oh!

Conversation

KevinZonda commented Aug 28, 2024

🤔 This is a ...

🔗 Related Issues

💡 Background and Solution

📝 Change Log

Uh oh!

bolt-new-by-stackblitz bot commented Aug 28, 2024

Uh oh!

github-actions bot commented Aug 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👁 Visual-Regression Diff Building... ⏳

Uh oh!

afc163 commented Aug 28, 2024

Uh oh!

KevinZonda commented Aug 29, 2024

Uh oh!

afc163 commented Sep 3, 2024

Uh oh!

coderabbitai bot commented Apr 13, 2025

Rate limit exceeded

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

afc163 commented Apr 13, 2025

Uh oh!

thinkasany Apr 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Aug 28, 2024 •

edited

Loading

github-actions bot commented Aug 28, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)