fix: the semantic error in Calendar description #6886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6886 +/- ##
==========================================
+ Coverage 92.76% 92.78% +0.01%
==========================================
Files 336 336
Lines 7230 7235 +5
Branches 1816 1818 +2
==========================================
+ Hits 6707 6713 +6
+ Misses 487 486 -1
Partials 36 36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
这样是否会让用户觉得点一次就已经完成了当日到当日的选择了。 |
按原本的逻辑, 第一次选择, 就已经设置了两个当日的时间. [当前日期, 当前日期] 之前有跟豆酱沟通过, 这个操作逻辑是有点别扭. 但因为原本的逻辑就是第一次选择的时候, 已经设置了 [开始, 结束]. |
afc163
approved these changes
Jun 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
原逻辑日期范围选择中, 第一次选中"开始"设置的是 [date1, date1] 而不是 [date1, 空值].
此时文案显示为 "开始", 第二次选中其他日期文案为 "结束", 设置第二个值 [date1, date2].
为了在不修改原逻辑, 而造成 breakchange.
所以将第一次选中的文案改为 "开始/结束", 作为语义修复的 Bug fix 来调整.
刚好可以解决该 issue 的问题 #6804