Fix #228 #237
Merged
Fix #228 #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR addresses issue #228 by updating the CBORValidator to include a new field (range_upper) and reworking validation logic for ranges, particularly for byte string (.size) validations. Key changes include:
- Adding a new field range_upper to CBORValidator and initializing it in multiple constructors.
- Refactoring range validation logic to handle different value types (including Bytes and Integer) with clearer error messages.
- Changing generic_rules args initialization from vec![] to Vec::new().
- Removing outdated comments and adding new tests for validating byte string size ranges.
Changes
| File | Description |
|---|---|
| src/validator/cbor.rs | Introduces range_upper field, adjusts range validation logic, and adds tests for .size range validations |
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #228