Overhaul VSCode extension #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes issue #248 where validating recursive CDDL structures would cause a stack overflow due to infinite recursion. Changes: - Added recursion detection to CBORValidator using visited_rules HashSet - Track visited rules during validation to prevent cycles - Allow recursive references by returning Ok() when a cycle is detected - Added comprehensive test case for recursive structure validation - Added helper method new_with_recursion_state() for proper state transfer The fix ensures that recursive structures like: Can be validated without causing stack overflow while maintaining validation correctness.
- Add visited_rules HashSet field to JSONValidator struct - Implement recursion detection in visit_identifier method - Handle recursive rule references in array processing - Add comprehensive tests for JSON validator recursion protection - Ensure both CBOR and JSON validators are protected against infinite recursion This extends the fix for issue #248 to cover both CBOR and JSON validation, providing comprehensive protection against stack overflow in recursive CDDL structures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up the VSCode extension