Skip to content

Conversation

dj-wasabi
Copy link

This PR contains the following change:

  • Creation/Deletion of Docker networks via the create.yml and delete.yml playbooks;

A filter molecule_get_docker_networks will be used that checks if a networks key is configured in the platforms. If so, it then checks if it has a name key and if that exists to, this name will be used with creating or deleting the docker network. If no networks key is configured in the platform (Or if so, but has no name key), then an empty list is returned and task is skipped.

Example usage for molecule.yml:

platforms:
  - name: ansible-docker
    image: milcom/centos7-systemd
    groups:
      - group1
    privileged: True
    networks:
      - name: my_fancy_network

If a better approach is needed, please let me know and I'll try again.
(I hope I have updated all correct test files :-) )

@jdvr
Copy link

jdvr commented Jan 20, 2018

Amazing work. Thank you.

@retr0h
Copy link
Contributor

retr0h commented Jan 20, 2018

Hi @dj-wasabi Can you update the cookiecutter molecule.yml with the whole default omit pattern.

Also, can you update the test files and docker driver (for documentation) as well. See #1092 for reference.

@retr0h retr0h added the v2.8 label Jan 20, 2018
@dj-wasabi
Copy link
Author

@retr0h

Thank you for the suggestion. I believe I have updated all files which were also in the PR you mentioned, if not please let me know and will update them to with this PR.

@retr0h
Copy link
Contributor

retr0h commented Jan 24, 2018

Hi @dj-wasabi can you be sure to update the docker driver class comments so the documentation gets updated. I believe #1092 does this for reference.

@dj-wasabi
Copy link
Author

Hi @retr0h Sorry! I thought I had updated that file to/

@retr0h retr0h merged commit d8b8689 into ansible:master Jan 24, 2018
@retr0h
Copy link
Contributor

retr0h commented Jan 24, 2018

@dj-wasabi Thanks as usual ! 🎸

@ssbarnea ssbarnea added this to the 2.8 milestone Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants