-
Notifications
You must be signed in to change notification settings - Fork 700
Fix Jinja template rendering error when concatenating _AnsibleTaggedStr with list #4737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request fixes compatibility between ansible-lint and ansible-core version 2.19 by addressing Jinja template rendering errors that occur when concatenating _AnsibleTaggedStr
objects with lists or strings.
- Adds regex patterns to handle concatenation errors with
_AnsibleTaggedStr
objects - Updates supported ansible-core versions to include 2.19
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
src/ansiblelint/rules/jinja.py | Adds regex patterns to handle _AnsibleTaggedStr concatenation errors in Jinja template rendering |
src/ansiblelint/config.py | Extends supported ansible-core versions to include 2.19 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…ible/ansible-lint into ansible_lint_19_core_support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test that templates a string and generates the message to see core generating it and us ignoring it?
Description- ansible-lint isn’t compatible with our current ansible-core version(2.19).
issue - #4702
related - https://issues.redhat.com/browse/AAP-51009