Skip to content

Conversation

anusshukla
Copy link
Contributor

@anusshukla anusshukla commented Aug 20, 2025

Description- ansible-lint isn’t compatible with our current ansible-core version(2.19).
issue - #4702
related - https://issues.redhat.com/browse/AAP-51009

@anusshukla anusshukla changed the title fix with the test cases Fix Jinja template rendering error when concatenating _AnsibleTaggedStr with list Aug 20, 2025
@anusshukla anusshukla self-assigned this Aug 20, 2025
@anusshukla anusshukla added the bug label Aug 20, 2025
@anusshukla anusshukla marked this pull request as ready for review August 20, 2025 12:55
@cidrblock cidrblock requested a review from Copilot August 20, 2025 13:00
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes compatibility between ansible-lint and ansible-core version 2.19 by addressing Jinja template rendering errors that occur when concatenating _AnsibleTaggedStr objects with lists or strings.

  • Adds regex patterns to handle concatenation errors with _AnsibleTaggedStr objects
  • Updates supported ansible-core versions to include 2.19

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/ansiblelint/rules/jinja.py Adds regex patterns to handle _AnsibleTaggedStr concatenation errors in Jinja template rendering
src/ansiblelint/config.py Extends supported ansible-core versions to include 2.19

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@anusshukla anusshukla marked this pull request as draft August 21, 2025 07:24
@anusshukla anusshukla marked this pull request as ready for review August 21, 2025 07:47
Copy link
Contributor

@cidrblock cidrblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test that templates a string and generates the message to see core generating it and us ignoring it?

@cidrblock cidrblock self-requested a review August 21, 2025 12:47
@github-project-automation github-project-automation bot moved this from In Progress to Review in 🧰 devtools project board Aug 21, 2025
@cidrblock cidrblock merged commit 359d866 into main Aug 21, 2025
27 checks passed
@cidrblock cidrblock deleted the ansible_lint_19_core_support branch August 21, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants