Set this back to DRAFT as SonarCloud Code Analysis CI job doesn't like the code. I kinda agree and will try simplify the implementation

I think the remaining CI errors are not cause by my PR, right?

I think the remaining CI errors are not cause by my PR, right?

I don't think so, but you may have help us find a bug:

WARNING  Skipped installing collection dependencies due to running in offline mode.
an AnsibleCollectionFinder has not been installed in this process
Command failed: got '1', expected '0'

#4734 should fix the action test (confirmed)

I changed the debug log statements for missing "local_action" and "module" param to assertions.

Code coverage went down because of the log statements and while trying to write test fixtures I realized a missing local_action would result in a non-matching rule, and a missing module param would be caught by the parser-error rule, also never reaching deprecated-local-action.

I think the assertions are fine here to guard against implementation errors.

@koalajoe23 Does this do everything you need now? Fun stuff. BTW, your intuition was right about needing a way to get out quick, it was part of the reason I threw in an exception, it also made adding some unit tests for the edge cases pretty straight forward with having to traverse the entire code base.

👍 for the changes. I really like the decoupled tests and error handling!

Only nitpick I have is that the transformed output should treat empty params as None - just looks much cleaner and "human". I took the liberty to just commit a fix, feel free to drop this commit if you want.

Everything LGTM on my part, awaiting merge :)