Fix mypy and pyright type checking errors #4724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove unused type: ignore comments that were causing mypy unused-ignore errors - Add type: ignore[no-any-unimported] for functions with AnsibleBaseYAMLObject parameters - Fix assignment type error in jinja.py by properly typing orig_exc as BaseException - Add pyright: ignore comments for import symbols and attribute access issues - Add type: ignore comments for AnsibleLoader and Origin compatibility across Ansible versions These changes resolve all remaining type checker errors while maintaining compatibility with different Ansible versions. The ignore comments are necessary due to conditional imports and version-specific type definitions in the Ansible ecosystem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves all remaining mypy and pyright type checking errors in the codebase while maintaining compatibility across different Ansible versions.
Background
The codebase had accumulated type checking errors due to:
type: ignorecomments that were no longer neededAnsibleBaseYAMLObjectparametersChanges Made
MyPy Error Resolution:
type: ignorecomments causingunused-ignoreerrorsjinja.pyby properly typingorig_excasBaseExceptiontype: ignore[no-any-unimported]for functions withAnsibleBaseYAMLObjectparameterstype: ignorecomments forAnsibleLoaderandOrigincompatibility issuesPyRight Error Resolution:
pyright: ignore[reportAttributeAccessIssue]for import symbols from conditional importspyright: ignore[reportAssignmentType]for cross-version type compatibilitypyright: ignore[reportAttributeAccessIssue]for internal Ansible/Jinja2 attribute accessTechnical Details
The ignore comments are necessary rather than proper fixes because:
Testing
tox -e lint -- mypypasses (0 errors, down from 44)tox -e lint -- pyrightpasses (0 errors, down from 10)This approach maintains type safety while respecting the complex compatibility requirements of the Ansible ecosystem.