Skip to content

Conversation

djdanielsson
Copy link
Contributor

@djdanielsson djdanielsson commented Jun 11, 2025

Related: #1710

@djdanielsson
Copy link
Contributor Author

is the issue that the current tests are not written with the unique names in mind and thus erroring or is there something else wrong with the code? also I wasn't sure the best way to add a test for this, if you could point me in that direction and how to fix the CI, I will try and get it all working

@Tompage1994
Copy link
Contributor

I love this idea. It seems like a pretty useful lint rule to have in the project. It will help drive good documented code rather than - name: Do a thing which is not far from what I've actually seen before

@ssbarnea ssbarnea added the bug label Jun 13, 2025
@ssbarnea ssbarnea changed the title adding unique name rule to the other name checking rules Adding rule to require unique task names Jun 13, 2025
@ssbarnea ssbarnea added enhancement and removed bug labels Jun 13, 2025
@ssbarnea ssbarnea enabled auto-merge June 13, 2025 16:06
@ssbarnea ssbarnea disabled auto-merge June 14, 2025 17:36
@ssbarnea ssbarnea added this pull request to the merge queue Jun 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jun 14, 2025
@ssbarnea ssbarnea added this pull request to the merge queue Jun 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jun 15, 2025
@ssbarnea ssbarnea added this pull request to the merge queue Jun 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jun 16, 2025
@ssbarnea ssbarnea merged commit e169572 into ansible:main Jun 17, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants