Use 'x-ansible-lint' key for path patterns in schema tests #4690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onlhart/ansible-lint into x-ansible-lint-schema-check
ad7721c to
3ede7ee
Compare
cidrblock
approved these changes
Jul 23, 2025
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Jul 30, 2025
This MR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pipx:ansible-lint](https://github.com/ansible/ansible-lint) ([changelog](https://github.com/ansible/ansible-lint/releases)) | `25.6.1` -> `25.7.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>ansible/ansible-lint (pipx:ansible-lint)</summary> ### [`v25.7.0`](https://github.com/ansible/ansible-lint/releases/tag/v25.7.0) [Compare Source](ansible/ansible-lint@v25.6.1...v25.7.0) #### Enhancements - Use 'x-ansible-lint' key for path patterns in schema tests ([#​4690](ansible/ansible-lint#4690)) [@​alisonlhart](https://github.com/alisonlhart) - Address disable\_lookups deprecation with ansible-core 2.19 ([#​4683](ansible/ansible-lint#4683)) [@​ssbarnea](https://github.com/ssbarnea) - Add auto-fixing implementation for pattern rule ([#​4679](ansible/ansible-lint#4679)) [@​shatakshiiii](https://github.com/shatakshiiii) - Remove patterns specific playbook meta folder ([#​4669](ansible/ansible-lint#4669)) [@​alisonlhart](https://github.com/alisonlhart) - Allow loading of yamllint config from a different location ([#​4644](ansible/ansible-lint#4644)) [@​dbrennand](https://github.com/dbrennand) - Add new rule to validate pattern directory structure ([#​4662](ansible/ansible-lint#4662)) [@​shatakshiiii](https://github.com/shatakshiiii) - Add play argspec schema validation to schema rule ([#​4667](ansible/ansible-lint#4667)) [@​alisonlhart](https://github.com/alisonlhart) - Add schema check for validating pattern specification file ([#​4653](ansible/ansible-lint#4653)) [@​shatakshiiii](https://github.com/shatakshiiii) - Enable testing with python 3.14 ([#​4637](ansible/ansible-lint#4637)) [@​ssbarnea](https://github.com/ssbarnea) #### Bugfixes - Check for gh\_action\_ref explicitly and document GHA inputs ([#​4701](ansible/ansible-lint#4701)) [@​alisonlhart](https://github.com/alisonlhart) - jinja spacing warning line-endings ([#​4691](ansible/ansible-lint#4691)) [@​anusshukla](https://github.com/anusshukla) - Handle lookup templating checks with ASTs ([#​4698](ansible/ansible-lint#4698)) [@​alisonlhart](https://github.com/alisonlhart) - Fix var-naming\[no-role-prefix] rule incorrectly applying to role variables ([#​4677](ansible/ansible-lint#4677)) [@​vills](https://github.com/vills) - schema: add missing subset 'systemd' to gather\_subset ([#​4664](ansible/ansible-lint#4664)) [@​eliba](https://github.com/eliba) - Fix typos in --list-tags help text ([#​4661](ansible/ansible-lint#4661)) [@​correctmost](https://github.com/correctmost) - Avoid import errors from filters when running in nodeps mode ([#​4651](ansible/ansible-lint#4651)) [@​ssbarnea](https://github.com/ssbarnea) #### Maintenance - packit: reformat, remove deprecated syntax and try merge queue ([#​4639](ansible/ansible-lint#4639)) [@​mfocko](https://github.com/mfocko) - Remove patch report from codecov ([#​4671](ansible/ansible-lint#4671)) [@​ssbarnea](https://github.com/ssbarnea) - Improve cspell configuration ([#​4668](ansible/ansible-lint#4668)) [@​ssbarnea](https://github.com/ssbarnea) - Update test deps ([#​4658](ansible/ansible-lint#4658)) [@​ssbarnea](https://github.com/ssbarnea) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS40NS4wIiwidXBkYXRlZEluVmVyIjoiNDEuNDUuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands schema tests to look for an
x-ansible-lintkey for file matching patterns.As part of the discussion on ansible/pattern-service#17, we have decided to allow using the schema key
x-ansible-lintto provide path examples for file types.For example, the patterns schema uses the value:
This is because the correct usage of an
exampleskey in JSON schemas is for JSON examples, not example file locations.Incorporates schema updates from #4673
Jira: AAP-49325